Skip to content

Fix up return descr - #331

Merged
dereuromark merged 4 commits into
2.xfrom
2.x-return
Oct 27, 2025
Merged

Fix up return descr#331
dereuromark merged 4 commits into
2.xfrom
2.x-return

Conversation

@dereuromark

Copy link
Copy Markdown
Member

Might solve #320

cc @othercorey

@dereuromark
dereuromark requested a review from markstory October 24, 2025 16:06
@dereuromark

dereuromark commented Oct 24, 2025

Copy link
Copy Markdown
Member Author

How does it work? Do we just (squash)merge and it auto deploys?

@LordSimal

Copy link
Copy Markdown
Contributor

Yes, it deploys via dokku, same as e.g. our docs

@dereuromark

Copy link
Copy Markdown
Member Author

I let @markstory do the honors

#https://didmarkbreakthebuild.com

@ADmad

ADmad commented Oct 27, 2025

Copy link
Copy Markdown
Member

https://github.com/cakephp/cakephp-api-docs/actions/runs/18749866024/job/53486286579?pr=331#step:3:172

Looks like the updated composer.lock is causing the build failure. You probably ran composer update on a PHP version higher than the one used by the dokku app.

@ADmad

ADmad commented Oct 27, 2025

Copy link
Copy Markdown
Member

Docker build failure is fixed by reverting the changes to composer.lock

@dereuromark

dereuromark commented Oct 27, 2025

Copy link
Copy Markdown
Member Author

thx!
we should add target version into composer platform config. this way it always updates correctly.

//EDIT I see now you already did in the other PR :)

@dereuromark
dereuromark merged commit 4ba46c6 into 2.x Oct 27, 2025
2 checks passed
@dereuromark
dereuromark deleted the 2.x-return branch October 27, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants